On Mon, Apr 28, 2008 at 10:53 AM, Brian Eaton <[EMAIL PROTECTED]> wrote:
> On Mon, Apr 28, 2008 at 12:11 AM, Kevin Brown <[EMAIL PROTECTED]> wrote: > > Between code migration, patches, cross talk, misinformation, and mass > > confusion, we seem to have gotten into a state of complete dysfunction > when > > it comes to our http retrieval facilities. Is anyone else actively > working > > on cleaning this stuff up right now, or should I go ahead and clean > this up > > myself? > > The OAuthFetcher is flat out broken since the caching change. It'd be > good to get it fixed before refactoring. > > What are your goals for this round of refactoring? Performance? > Readability? Ease of adding some particular new feature Primarily readability, maintainability (hahahah...), and ease of extending / modifying. I've been able to force it to working for the google implementation, but it's ugly as sin and relies on several unnecessary workarounds. I didn't realize that OAuthFetcher was completely broken. I thought it was just "mostly broken" :).
