[
https://issues.apache.org/jira/browse/SHINDIG-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597677#action_12597677
]
David Primmer commented on SHINDIG-240:
---------------------------------------
First, this does work but how do you isolate the cross component dependencies
in Eclipse if you have every source folder part of one project? I can import
gadgets files from social-api this way, which should be illegal.
Second, are you comparing the patch to the file that exists? It does retain
most of the content but tries to organize it better. One command in the
instructions replaces the 3 of the steps you just mentioned. The complexity may
be the result of me leaving in the existing painful plugin-less instructions.
It seems your complaint would apply even more to the existing instructions and
I'd assume you would support a patch that removes them but they were added by
someone else who thought using eclipse without the sonatype plugins was a
viable route. That's not my addition. I feel like my instructions clarify that
there are two routes, one simple one that uses the sonatype plugin and one that
doesn't. The instructions are
* Create the Eclipse Project files
* Import the Projects
* Clean up some Build Path errors.
> improve the maven eclipse instructions
> --------------------------------------
>
> Key: SHINDIG-240
> URL: https://issues.apache.org/jira/browse/SHINDIG-240
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: David Primmer
> Priority: Minor
> Attachments: build_java_eclipse_update.patch
>
>
> include patch to update the instructions to be more clear depending on
> whether the user has the M2Eclipse Eclipse plugin.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
