[
https://issues.apache.org/jira/browse/SHINDIG-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598776#action_12598776
]
Kevin Brown commented on SHINDIG-294:
-------------------------------------
"resultsFound" does need to be a Set because it is used to flatten the
dependency graph. If your needed is:
{"rpc", "opensocial-0.7"}
And your input is a List, you'd get back:
{"rpc", "core", "opensocial-0.7", "core", "opensocial-reference", "core",
"rpc", "core"}
Resulting in rpc and core code being seen multiple times in the output.
Whereas if it was a set you'd get back:
{"core", "rpc", "opensocial-reference", "opensocial-0.7"}
A Collection is fine for "needed" and "missing" though, of course.
Also, we intentionally don't use final parameters (only final classes and
members).
> GadgetFeatureRegistry needs not to be restricted on Sets
> --------------------------------------------------------
>
> Key: SHINDIG-294
> URL: https://issues.apache.org/jira/browse/SHINDIG-294
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: collection.patch
>
>
> Actually, Collection is fine and it allows to pass in things like
> Arrays.asList(<stuff>).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
