[
https://issues.apache.org/jira/browse/SHINDIG-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598975#action_12598975
]
Henning Schmiedehausen commented on SHINDIG-294:
------------------------------------------------
Actually, after getting some sleep and thinking about your first comment
(https://issues.apache.org/jira/browse/SHINDIG-294?focusedCommentId=12598776#action_12598776),
I tend to disagree with myself. Allowing Collections to be passed in for all
parameters can be a good thing because it places policy in the hand of the
caller. If you can only pass in a set, you are e.g. not able to find out if a
library might be used multiple times.
So I now believe, that having all three parameters as collection is a good
thing, because it does not break anything (only if you insist on passing in a
list, you are in trouble) but allows more flexibility.
I attach a second patch with clarified java docs and the final qualifiers
removed.
> GadgetFeatureRegistry needs not to be restricted on Sets
> --------------------------------------------------------
>
> Key: SHINDIG-294
> URL: https://issues.apache.org/jira/browse/SHINDIG-294
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Henning Schmiedehausen
> Attachments: collection.patch
>
>
> Actually, Collection is fine and it allows to pass in things like
> Arrays.asList(<stuff>).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
