Looks great
http://codereview.appspot.com/13047/diff/1013/1026 File java/common/src/main/java/org/apache/shindig/expressions/JsonELResolver.java (right): http://codereview.appspot.com/13047/diff/1013/1026#newcode117 Line 117: if (property instanceof Number) { any need to check for property == null? You use String.valueOf which insulates you in other places. Could mess with instanceof check. http://codereview.appspot.com/13047/diff/1013/1039 File java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetELResolver.java (right): http://codereview.appspot.com/13047/diff/1013/1039#newcode91 Line 91: return ImmutableMap.of(); Any reason not to use empty json object? http://codereview.appspot.com/13047/diff/1013/1034 File java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java (right): http://codereview.appspot.com/13047/diff/1013/1034#newcode106 Line 106: // List<Object> aliases = Arrays.<Object>asList("some-alias", "alias"); cleanup? http://codereview.appspot.com/13047/diff/1013/1040 File pom.xml (right): http://codereview.appspot.com/13047/diff/1013/1040#newcode232 Line 232: </roles> separate patch. http://codereview.appspot.com/13047
