Chris the problem isnt maven (this time)
I have excluded *all* eol editing so after 774369 the php assembly
*is* identical to the tar pipe you mentioned.
What I am trying to find out is:
Should release artifacts be identical regardless of if they are built
on windows or unix (ie unix line endings regardless)?
or
Is it Ok for the artifact to have the line ending of the box it was
checked out from SVN and built on (php files are svn-eol:native) ?
You have already identified one area of concern with the php tests.
With the svn-eol setting as native for php, which will result in dos
line endings when checked out on a dos machine do the tests still work?
If you really do just want tar c shindig/php | gzip > release.tar.gz
then I am happy to leave it as post 774369 and assume a Shindig
release will not be cut on a windows box.
Ian
On 13 May 2009, at 15:35, Chris Chabot wrote:
The 'problem' is that the \n's that php-shindig produced (and it
only adds
those when formatting the responses, which it only does when
debugging =
true ie the default configuration) and the unit tests test against
the same.
Another issue with releasing a package with windows line endings is
that if
someone would ever want to do a patch against a svn checkout, we
might risk
getting --entire file ++entire file with windows line endings patches
Sigh, why is it so hard to do tar c shindig/php | gzip >
release.tar.gz in
maven, sure makes life more complicated ;/ Please some one find a
'don't
touch php files' switch before I regret conceding to using maven for
building releases :)
On Wed, May 13, 2009 at 4:10 PM, Ian Boston <i...@tfd.co.uk> wrote:
On 13 May 2009, at 15:01, Chris Chabot wrote:
is there really no
exclude_rewrite=*.php flag that can be set somewhere in that
mysterious
maven configuration?
mysterious or magical, hard to tell sometimes :),
we could split the package into text and non text and put the php
in the
non text to exclude the php files.
But that would make the php files in the release depend on the
platform the
release was built on.
What is the eol-style in svn for these files ?
Ian
