On Wed, May 13, 2009 at 4:59 PM, Ian Boston <i...@tfd.co.uk> wrote: > Chris the problem isnt maven (this time) > I have excluded *all* eol editing so after 774369 the php assembly *is* > identical to the tar pipe you mentioned. >
Awesome! :) > > What I am trying to find out is: > > Should release artifacts be identical regardless of if they are built on > windows or unix (ie unix line endings regardless)? > or > Is it Ok for the artifact to have the line ending of the box it was checked > out from SVN and built on (php files are svn-eol:native) ? > Preferably they should always have unix style line endings, however the chances that php developers will run maven to package php files are rather low, so if the above is not the case, I think it's safe to ignore for now > > You have already identified one area of concern with the php tests. > With the svn-eol setting as native for php, which will result in dos line > endings when checked out on a dos machine do the tests still work? > We got a couple of guys in Beijing who work primarily on windows machines, and the tests seem to work well for them even though they did a svn checkout on windows. When I tried the original mvn php archive that was produced in the first release cut, it did make tests fail... so while it's all just anecdotal evidence, it seems to work out well as-is. > > If you really do just want tar c shindig/php | gzip > release.tar.gz then I > am happy to leave it as post 774369 and assume a Shindig release will not be > cut on a windows box. > Works for me, Thanks for taking the time to follow up on this Ian! -- Chris
