Yeah I have no idea why the patch got so messed up. As to SHINDIG-1199 -- I've (locally) made these modifications. We should be able to discard them. BrowserSpecificFeatureResource continues to flummox me. I'm trying this again...
--j On Wed, Oct 28, 2009 at 4:15 PM, <jon.weyga...@gmail.com> wrote: > I just tried to "svn update" and apply the patch. There are issues with > the deleted versions of JsFeatureLoader.java, > BrowserSpecificRpcJsFeatureLoader.java, > OpenSocialI18NGadgetRewriter.java. Depending upon your code base, the > SHINDIG-1199 patch was recently applied to those files > (OpenSocialI18NGadgetRewriter was modified on 10/14, prior to the 10/27 > SHINDIG-1199 patch). If that's the only issue, let's discard > SHINDIG-1199, and try to apply them manually to the latest version. > > As to BrowserSpecificFeatureResource.java (the new one), it does not > patch right. Take a look at the diff, most of the new files have > (revision 0) for both versions, and simply all added lines, but not > BrowserSpecificFeatureResource. > > > http://codereview.appspot.com/143046 >
