On Thu, Oct 29, 2009 at 3:23 PM, <jon.weyga...@gmail.com> wrote: > On 2009/10/29 16:42:20, johnfargo wrote: > >> Source control and patch don't play very nicely at all in anything but >> > M > >> situations. Trying again. >> > > I got the patch downloaded, built and tried it out in my build - just to > the point of compiling. Looks OK, I applied the "cache" fix from: > http://codereview.appspot.com/124086/show to it. Plus did the private to > public changes. > > Since I cannot post a patch to this review, create a new one: > http://codereview.appspot.com/144055. >
Great, thanks -- I'll pick this up and diff it w/ mine (in this parent thread). > > BTW - noticed in my build some tests failed when building, don't know if > that is simply me, or there are some issues with the patch. Checking that out now... > > > http://codereview.appspot.com/143046 >
