[
https://issues.apache.org/jira/browse/SHINDIG-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609863#action_12609863
]
Chris Chabot commented on SHINDIG-355:
--------------------------------------
OAuth.php, function build_signature:
$ok = openssl_sign($base_string, $signature, $privatekeyid);
// Release the key resource
openssl_free_key($privatekeyid);
return base64_encode($signature);
}
$ok is a boolean return value, but it's never checked if it was successful or
not. It's -always- a good idea to check return values, and throw errors if a
call failed. Otherwise if errors are 'hidden' debugging becomes a lot harder.
> OAuth in gadget xml spec
> -------------------------
>
> Key: SHINDIG-355
> URL: https://issues.apache.org/jira/browse/SHINDIG-355
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Attachments: feature-SHINDIG-355.patch
>
>
> Instead of having a new oauth feature, the proposal is to put it directly
> into the gadget xml spec. Should parse and support the oauth feature.
> See:
> http://www.google.com/url?q=http://groups.google.com/group/opensocial-and-gadgets-spec/browse_frm/thread/a1ce63eecfb21cad&sa=D&usg=ALhdy2-tUxagajVfd0hx98L5CubK3S340Q
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
