[
https://issues.apache.org/jira/browse/SHINDIG-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609878#action_12609878
]
Chris Chabot commented on SHINDIG-355:
--------------------------------------
Ah i see what i did wrong, i didn't replace
http://dirk.balfanz.googlepages.com/contacts.xml with
http://opensocial-gaune.googlecode.com/files/contacts.xml in the oauth.json
file. Still the 'handle errors properly' remark stands :)
After fixing that error, it's working perfectly.
Except for the issues mentioned above, the code looks solid and well written,
i'll apply it (with my fixes that i mentioned above), but can you please
re-check the basic error handling?
ie, remove the oauth.json key for a gadget, make sure you give a proper error
instead of php notices&errors. Change the consumer_secret_key, and see if that
error is caughtr correctly.. change the consumer_key and see what that does ...
break the oauth.json config, and see what that does.. change the key type, and
... well you catch my drift right? :)
> OAuth in gadget xml spec
> -------------------------
>
> Key: SHINDIG-355
> URL: https://issues.apache.org/jira/browse/SHINDIG-355
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Attachments: feature-SHINDIG-355.patch
>
>
> Instead of having a new oauth feature, the proposal is to put it directly
> into the gadget xml spec. Should parse and support the oauth feature.
> See:
> http://www.google.com/url?q=http://groups.google.com/group/opensocial-and-gadgets-spec/browse_frm/thread/a1ce63eecfb21cad&sa=D&usg=ALhdy2-tUxagajVfd0hx98L5CubK3S340Q
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
