[
https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616917#action_12616917
]
Cassie Doll commented on SHINDIG-465:
-------------------------------------
I think these changes will be great but I can't use the patch that you attached
because its format is off. If you could do the following:
cd <your shindig root>
svn diff > samplecontainer-javascript-improvements-003.patch
and attach that new patch to this bug then i should be able to patch it into my
client.
Thanks!
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-002.patch
>
>
> I've removed the javascript from the samplecontainer.html file and put it
> into a javascript file. I've also slightly adjusted the javascript code to
> comply with the current javascript best practices. I've put everything into a
> general shindig namespace, with a samplecontainer subnamespace. Then I've put
> all the javascript code into a closure to stop it from polluting the global
> namespace. Only the functions that needed to be visible outside of this
> javascript scope have been put public inside the shindig namespace,
> everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
