[
https://issues.apache.org/jira/browse/SHINDIG-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolaas Matthijs updated SHINDIG-465:
--------------------------------------
Attachment: samplecontainer-javascript-improvements-003.patch.txt
Adjusted the patch so that it works with "patch -p0" in stead of "patch -p1".
Tested this on a clean svn checkout and seems to be working.
> Samplecontainer Javascript Improvement
> --------------------------------------
>
> Key: SHINDIG-465
> URL: https://issues.apache.org/jira/browse/SHINDIG-465
> Project: Shindig
> Issue Type: Improvement
> Components: Sample container & Examples
> Reporter: Nicolaas Matthijs
> Attachments: samplecontainer-javascript-improvements-003.patch.txt
>
>
> I've removed the javascript from the samplecontainer.html file and put it
> into a javascript file. I've also slightly adjusted the javascript code to
> comply with the current javascript best practices. I've put everything into a
> general shindig namespace, with a samplecontainer subnamespace. Then I've put
> all the javascript code into a closure to stop it from polluting the global
> namespace. Only the functions that needed to be visible outside of this
> javascript scope have been put public inside the shindig namespace,
> everything else is private now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
