I made one other change in the second patch, which was for SocialSpiException to inherit from RuntimeException. When I tried implementing against the API, that proved to be much easier than exposing SocialSpiException everywhere, especially where my codebase works with APIs like the Function interface from Google Collections.
-- Adam On Thu, Aug 28, 2008 at 2:20 PM, Ian Boston <[EMAIL PROTECTED]> wrote: > Ok, no worries svn/diff patches dont work well with moves, > The new location is good. > so the patch instructions are > mv then patch > > One patch is just fine, I will try again. > Thanks > Ian > > On 28 Aug 2008, at 17:23, Adam Winer wrote: > >>> >>> This looks like a move and then a diff on the result of the move ? >> >> Yes, that's what the patch is trying to do. >> >>> Should this be preceded by a mv >>> java/social-api/src/main/java/org/apache/shindig/social/ResponseItem.java >>> >>> java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/ResponseItem.java >>> ? >> >> Or followed by it, since ResponseItem doesn't really belong in >> opensocial/service until this patch is in. Would you rather we keep >> ResponseItem where it is for this patch, and move it in a second >> patch? >> >> -- Adam > >
