[
https://issues.apache.org/jira/browse/SHINDIG-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626774#action_12626774
]
Ian Boston commented on SHINDIG-549:
------------------------------------
Patch is good, all the maven tests run, as does the hello gadget. The
compliance tests generate the same number of errors and warnings before and
after the patch. Coverage and Style reports are unchanged.
The patch looks good and Ok to commit, I will wait till tomorrow to commit to
give others a chance to comment.
> Use exceptions instead of ResponseItem to signal service errors
> ---------------------------------------------------------------
>
> Key: SHINDIG-549
> URL: https://issues.apache.org/jira/browse/SHINDIG-549
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Adam Winer
> Attachments: shindig-549-2.patch, shindig-549.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> As discussed on shindig-dev:
> (1) Get error code and message out of
> RestfulItem/RestfulCollection/DataCollection and into an exception,
> so:
> PersonService {
> Future<RestfulCollection<Person>> getPeople(...);
> Future<RestfulItem<Person>> getPerson(...);
> }
> becomes:
> PersonService {
> // Note: the Future may also throw a SocialApiException (wrapped in
> an EvaluationException)
> Future<RestfulCollection<Person>> getPeople(...) throws SocialApiException
> Future<Person> getPerson(...) throws SocialApiException
> }
> RestfulItem goes away entirely, and RestfulCollection doesn't extend
> ResponseItem. ResponseItem can entirely disappear from the SPI, and
> can move out of org.apache.shindig.social and into
> o.a.s.s.opensocial.service alongside of RequestItem.
> One advantage of this change is that it makes it easy to write generic
> preconditions across datatypes, and gets rid of early returns from
> service implementations, which are a bit of a code smell.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
