[
https://issues.apache.org/jira/browse/SHINDIG-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Hjelmstad updated SHINDIG-500:
-----------------------------------
Attachment: gadgetspec-immutable.patch
Attaching latest patch making gadgetSpec immutable, cleaning up its interface,
adding setContent() to Gadget, adding ContentRewriterRegistry.rewriteGadget(),
and pulling up rewriting logic into GadgetServer (until it's moved again to the
new rendering pipeline). The CL also maintains caching of rewritten gadget
specs, for good measure... once submitted, we can move to the more satisfying
task of cleaning up APIs to obviate the need for additional layers of caching,
as commented here.
All unit tests, including new ones, pass just fine, but for some reason I can't
figure out my client errors on java/server's EndToEndTest. Reason: 404 on
/gadgets/testframework.js, which should have nothing to do with my changes.
In printf-debugging (Eclipse is hugely painful for this one) this, I discovered
that the rewriter is doing precisely the same thing with and without my
changes: rewriting <script src="testframework.js"/> to <script
src="/gadgets/concat?stuff..."/>. Why /gadgets/testframework.js 404s then, I
don't know. Ian, any clues?
> Make Gadget Object's content that of the active View
> ----------------------------------------------------
>
> Key: SHINDIG-500
> URL: https://issues.apache.org/jira/browse/SHINDIG-500
> Project: Shindig
> Issue Type: Sub-task
> Components: Gadget Rendering Server (Java)
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Attachments: gadgetspec-immutable.patch
>
>
> Step #1 of
> http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200808.mbox/[EMAIL
> PROTECTED]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
