[ 
https://issues.apache.org/jira/browse/SHINDIG-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Hjelmstad updated SHINDIG-500:
-----------------------------------

    Attachment: spec-immutable-notdoneyet.patch

Attached an updated (accommodating the latest merges) patch making GadgetSpec 
immutable once more, and moving get/setContent into Gadget. This patch isn't 
complete yet, pending resolution of the rewritten-content caching issue: 
notably, that rewritten content is not cached in this change.

Per previous discussion, I see two ways to resolve this:
1. Introduce a new rewrittenContent cache.
2. Move BasicGadgetSpecFactory's cache up to GadgetServer (this in turn is 
being refactored now as well, and the cache should go with it when that 
happens).

Thinking on it some more, in either case there's a rewritten content cache 
introduced at the same level that performs content rewriting: notably, 
GadgetServer for now. I'll introduce that and supply a new patch. Past that we 
need to determine whether to keep the BasicGadgetSpecFactory cache or not (I'd 
vote not, as it's largely redundant).

> Make Gadget Object's content that of the active View
> ----------------------------------------------------
>
>                 Key: SHINDIG-500
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-500
>             Project: Shindig
>          Issue Type: Sub-task
>          Components: Gadget Rendering Server (Java)
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>         Attachments: spec-immutable-notdoneyet.patch
>
>
> Step #1 of 
> http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200808.mbox/[EMAIL
>  PROTECTED]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to