[
https://issues.apache.org/jira/browse/SHINDIG-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627991#action_12627991
]
Chris Chabot commented on SHINDIG-543:
--------------------------------------
Hi Ram,
I'm missing one thing in that patch, and that is the detection of the
opensocial-X.Y version to use as discussed in an earlier comment, right now the
patch lists:
$supportedFields = $config['opensocial-0.8']['supportedFields'];
Instead it should loop through the $config keys, match it against "opensocial-"
and then pick the highest one (in case multiple opensocial-* entries are ever
encountered).
Oh and you have an IF statement without {}'s, which is just asking for bugs in
the long term :)
If you could please correct those 2 issues, i'll apply it asap; Thanks!
> Get supportedFields through the RESTful API
> -------------------------------------------
>
> Key: SHINDIG-543
> URL: https://issues.apache.org/jira/browse/SHINDIG-543
> Project: Shindig
> Issue Type: New Feature
> Components: RESTful API (PHP)
> Reporter: Chris Chabot
> Priority: Critical
> Attachments: DataRequestHandler.php.patch
>
>
> See
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/2ce4adb503576439?hl=en
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
