[ 
https://issues.apache.org/jira/browse/SHINDIG-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Chabot resolved SHINDIG-543.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

My apologies for the slight delay in getting to this, was out of town for a 
week.

There were 2 small issues with the patch, one was the missing {}'s in the first 
if / else statement (this leads to subtle bugs down the road), and also there 
was no error checking for if no opensocial-foo.bar key was found, so i changed 
that too:

        if (!count($version)) {
                throw new Exception("Invalid container configuration, 
opensocial-x.y key not found");
        }
        rsort($version);
        return $version[0];

After making those 2 small modifications, the patch is great! Another item of 
our todo list done, thanks for the great work!

> Get supportedFields through the RESTful API
> -------------------------------------------
>
>                 Key: SHINDIG-543
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-543
>             Project: Shindig
>          Issue Type: New Feature
>          Components: RESTful API (PHP)
>            Reporter: Chris Chabot
>            Assignee: Chris Chabot
>            Priority: Critical
>         Attachments: DataRequestHandler.php.patch
>
>
> See 
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/2ce4adb503576439?hl=en

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to