[
https://issues.apache.org/jira/browse/SHINDIG-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628276#action_12628276
]
Chris Chabot commented on SHINDIG-538:
--------------------------------------
Hey Joseph, amazing work! Going through the patch now.
There are some formatting issues, but the IDE will take care of that so no
complaints there.
This bit of code looks a bit off though:
class CollectionOptions {
public function __construct()
{
// set default values, per spec
$startIndex = 0;
$count = 0;
$sortOrder = CollectionOptions::SORT_ORDER_ASCENDING;
}
}
You probably meant $this->stuff ? :)
Will post more comments if i run into more issues
> PortableContacts alignment
> --------------------------
>
> Key: SHINDIG-538
> URL: https://issues.apache.org/jira/browse/SHINDIG-538
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: Chris Chabot
> Priority: Blocker
> Attachments: shindig-pc-diff.txt
>
>
> In the 0.8.1 spec revision we decided to align the OpenSocial REST API with
> PortableContacts to improve data portability.
> This means both the src/social-api/opensocial/model's, and the service
> adapter return structure changed to match the specifications.
> See http://portablecontacts.net/draft-spec.html for an overview on
> PortableContact's spec, and
> http://docs.google.com/View?docid=dcc2jvzt_37hdzwkmf8 for some of the changes
> this had on how the REST protocol works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
