[
https://issues.apache.org/jira/browse/SHINDIG-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658357#action_12658357
]
Kevin Brown commented on SHINDIG-806:
-------------------------------------
I support this move as well, as long as the packaging remains such that the
'out of the box' setup for both languages continues to work without issue.
While we're at it, we can fix the location of the default container
configuration as well.
> Move Javascript in the features directory in a better location
> --------------------------------------------------------------
>
> Key: SHINDIG-806
> URL: https://issues.apache.org/jira/browse/SHINDIG-806
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Affects Versions: 1.0.x-incubating
> Reporter: Henning Schmiedehausen
> Attachments: SHINDIG-806.patch
>
>
> Having the feature subdirectories right under the features folder is actually
> some kind of PITA whenever you want to turn this into an IDE project (e.g.
> eclipse). I'd like to move the javascript into src/main/javascript and the
> tests into src/test/javascript. This also would allow to package up the code
> without the tests.
> However, this is either one really, really big patch or small one with a
> number of additional file moves:
> the following files go into src/test/javascript/<subdirectory>
> ./core/authtest.js
> ./core.io/iotest.js
> ./core/prefstest.js
> ./core/utiltest.js
> ./mocks/env.js
> ./mocks/xhr.js
> ./opensocial-base/jsonactivitytest.js
> ./opensocial-reference/activitytest.js
> ./opensocial-templates/compiler_test.js
> ./opensocial-templates/container_test.js
> ./opensocial-templates/data_test.js
> ./opensocial-templates/domutil.js
> ./opensocial-templates/loader_test.js
> ./opensocial-templates/os_test.js
> ./opensocial-templates/ost_test.html
> ./opensocial-templates/README
> ./opensocial-templates/template_test.js
> ./opensocial-templates/util_test.js
> ./views/urltemplatetest.js
> Then move the following directories:
> analytics auth-refresh caja core core.io dynamic-height flash locked-domain
> opensocial-* pubsub rpc setprefs settitle skins tabs views and feature.txt to
> src/main/javascript
> mocks to src/test/javascript
> And apply the attached patch. Then the features directory builds as a "real"
> maven project; also the produced jar no longer contains the test javascript.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
