[
https://issues.apache.org/jira/browse/SHINDIG-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658583#action_12658583
]
Chris Chabot commented on SHINDIG-806:
--------------------------------------
I haven't recieved any 'sync with php folks' type emails yet, so i presume this
is still in the works? :)
As long as i can do a glob on some <shindig>/foo/bar/<feature dirs> directory,
the location isn't in the java directory, and you let me know when you commit
it, it won't break any php code.
Alternativly you can also modify this your self, edit
shindig/php/config/container.php and change:
'features_path' => realpath(dirname(__FILE__) . '/../../features') . '/',
into the new location, so it would become something like:
'features_path' => realpath(dirname(__FILE__) .
'/../../features/src/main/javascript ') . '/',
I don't see how shindig/features/src/main/javascript is supposed to be 'IDE
friendly' btw, but looking at the deep tree's Java projects have
(com.apache.foo.bar.left.right.and.top.package anyone?) I can imagine you would
feel uncomfortable if there are just 2 directory levels? :) (with less pun: If
it helps I'm all for it, but fail to see the need my self)
> Move Javascript in the features directory in a better location
> --------------------------------------------------------------
>
> Key: SHINDIG-806
> URL: https://issues.apache.org/jira/browse/SHINDIG-806
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript)
> Affects Versions: 1.0.x-incubating
> Reporter: Henning Schmiedehausen
> Attachments: SHINDIG-806.patch
>
>
> Having the feature subdirectories right under the features folder is actually
> some kind of PITA whenever you want to turn this into an IDE project (e.g.
> eclipse). I'd like to move the javascript into src/main/javascript and the
> tests into src/test/javascript. This also would allow to package up the code
> without the tests.
> However, this is either one really, really big patch or small one with a
> number of additional file moves:
> the following files go into src/test/javascript/<subdirectory>
> ./core/authtest.js
> ./core.io/iotest.js
> ./core/prefstest.js
> ./core/utiltest.js
> ./mocks/env.js
> ./mocks/xhr.js
> ./opensocial-base/jsonactivitytest.js
> ./opensocial-reference/activitytest.js
> ./opensocial-templates/compiler_test.js
> ./opensocial-templates/container_test.js
> ./opensocial-templates/data_test.js
> ./opensocial-templates/domutil.js
> ./opensocial-templates/loader_test.js
> ./opensocial-templates/os_test.js
> ./opensocial-templates/ost_test.html
> ./opensocial-templates/README
> ./opensocial-templates/template_test.js
> ./opensocial-templates/util_test.js
> ./views/urltemplatetest.js
> Then move the following directories:
> analytics auth-refresh caja core core.io dynamic-height flash locked-domain
> opensocial-* pubsub rpc setprefs settitle skins tabs views and feature.txt to
> src/main/javascript
> mocks to src/test/javascript
> And apply the attached patch. Then the features directory builds as a "real"
> maven project; also the produced jar no longer contains the test javascript.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
