[
https://issues.apache.org/jira/browse/SHINDIG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663511#action_12663511
]
Kevin Brown commented on SHINDIG-833:
-------------------------------------
It looks like items 1 and 3 are addressed. Item 2 doesn't seem to make much
sense; implementations already effectively do an isLoggable check before
actually writing to the log, so there's no real performance gain to be had.
Performance benefits can be achieved by using the logging call variants that
take arguments, though.
> Improve Java code and performance
> ---------------------------------
>
> Key: SHINDIG-833
> URL: https://issues.apache.org/jira/browse/SHINDIG-833
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server
> (Java), RESTful API (Java)
> Affects Versions: trunk
> Reporter: Vincent Siveton
>
> The Java code needs to be improved to fix some performance issues and common
> errors.
> * SHINDIG-832 includes fixes to increase visibility of some fields/methods
> * calling log like logger.XXX() should be precede by if (logger.isLoggable(
> XXX ))...
> * fix file leaks, missing final.... You could read the findbugs or PMD
> reports (see SHINDIG-827)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
