[
https://issues.apache.org/jira/browse/SHINDIG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663529#action_12663529
]
Vincent Siveton commented on SHINDIG-833:
-----------------------------------------
bq: It looks like items 1 and 3 are addressed. Item 2 doesn't seem to make much
sense;
item 1: SHINDIG-832 doesn't increase visibility of fields, but IMHO it is not a
big deal since modern compilers will do the job (but if you are a purist it is
recommended approach)
item 2: Well, using isLoggable() method is to avoid data creation for a logging
call that does not get logged and IMHO it is a best practice. BTW it could be
related to SHINDIG-259. We could discuss it on dev@
item 3: yes SHINDIG-827 has been applied but if you take care of the reports,
you will see a lot of errors. So we need to have a code review.
> Improve Java code and performance
> ---------------------------------
>
> Key: SHINDIG-833
> URL: https://issues.apache.org/jira/browse/SHINDIG-833
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java), Gadget Rendering Server
> (Java), RESTful API (Java)
> Affects Versions: trunk
> Reporter: Vincent Siveton
>
> The Java code needs to be improved to fix some performance issues and common
> errors.
> * SHINDIG-832 includes fixes to increase visibility of some fields/methods
> * calling log like logger.XXX() should be precede by if (logger.isLoggable(
> XXX ))...
> * fix file leaks, missing final.... You could read the findbugs or PMD
> reports (see SHINDIG-827)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
