[
https://issues.apache.org/jira/browse/SHINDIG-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot closed SHINDIG-977.
--------------------------------
Resolution: Fixed
Patch is now invalid since this issue has been addressed in the patch from
SHINDIG-978
> Wrong tests
> -----------
>
> Key: SHINDIG-977
> URL: https://issues.apache.org/jira/browse/SHINDIG-977
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Jakub Vrána
> Priority: Minor
> Attachments: shindig-977.diff
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> 1. Some files with tests (e.g. gadgets/ViewSpecTest.php) are empty. These are
> probably kind of TODO but PHPUnit fails on them.
> 2. Output*ConverterTests call RestRequestItem::createWithRequest() with
> $token set to null. This issues PHP catchable fatal error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
