[
https://issues.apache.org/jira/browse/SHINDIG-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Hjelmstad updated SHINDIG-852:
-----------------------------------
Attachment: SHINDIG-852-2.patch
New patch attached, implementing:
1. ProxyServletRequest appends query string verbatim to the proxied-content
URL, when available.
- Class *still* URIDecodes the proxy URL, in order to accommodate those who
are using chained syntax with %url% rather than %rawurl%.
- question: Is this the right decision? This implementation has the potential
to break chained-proxied content if the actual target URL before the query
string has URIEncoded data in it and requires that this be so. In my experience
this is fairly rare, but not impossible (eg. URLs like
http://www.foo.com/hello%20world/). URLs of this type are the same that would
have broken with the previous change, however. I didn't hear about any
incompatibilities then so I'm assuming this compatibility feature is reasonable.
2. Updates ProxyServletRequestTest to more accurately mock getRequestURI() and
getQueryString() on HttpServletRequest.
> Chained syntax in proxy doesn't support URLs with query arguments
> -----------------------------------------------------------------
>
> Key: SHINDIG-852
> URL: https://issues.apache.org/jira/browse/SHINDIG-852
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: John Hjelmstad
> Assignee: John Hjelmstad
> Fix For: trunk
>
> Attachments: SHINDIG-852-2.patch, shindig-852.patch
>
>
> When using the proxy's chained syntax, eg:
> http://gadget-server.com/gadgets/proxy/refresh=3600/[url]
> Query arguments are dropped when [url] contains any query params. This is
> true whether <url> is URI escaped or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
