[jira] Commented: (SHINDIG-857) public key id param key should be xoauth_public_key

[Paul Lindner (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SHINDIG-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737756#action_12737756
 ] 

Paul Lindner commented on SHINDIG-857:
--------------------------------------

Here's a java patch that preserves the old key and adds the new

diff --git 
a/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 
b/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
index eb0bc22..6cf9127 100644
--- 
a/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
+++ 
b/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
@@ -90,7 +90,10 @@ public class OAuthRequest {
 
   protected static final String OPENSOCIAL_PROXIED_CONTENT = 
"opensocial_proxied_content";
 
-  protected static final String XOAUTH_PUBLIC_KEY = 
"xoauth_signature_publickey";
+  // old and new parameters for the public key
+  // TODO remove OLD in a far future release
+  protected static final String XOAUTH_PUBLIC_KEY_OLD = 
"xoauth_signature_publickey";
+  protected static final String XOAUTH_PUBLIC_KEY_NEW = 
"xoauth_signature_publickey";
 
   protected static final Pattern ALLOWED_PARAM_NAME = 
Pattern.compile("[-:\\...@$*()_\\[\\]:,./]+");
 
@@ -446,7 +449,8 @@ public class OAuthRequest {
           new Parameter(OAuth.OAUTH_CONSUMER_KEY, 
realRequest.getSecurityToken().getDomain()));
     }
     if (accessorInfo.getConsumer().getKeyName() != null) {
-      params.add(new Parameter(XOAUTH_PUBLIC_KEY, 
accessorInfo.getConsumer().getKeyName()));
+      params.add(new Parameter(XOAUTH_PUBLIC_KEY_OLD, 
accessorInfo.getConsumer().getKeyName()));
+      params.add(new Parameter(XOAUTH_PUBLIC_KEY_NEW, 
accessorInfo.getConsumer().getKeyName()));
     }
     params.add(new Parameter(OAuth.OAUTH_VERSION, OAuth.VERSION_1_0));
     params.add(new Parameter(OAuth.OAUTH_TIMESTAMP,

> public key id param key should be xoauth_public_key
> ---------------------------------------------------
>
>                 Key: SHINDIG-857
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-857
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>    Affects Versions: 1.1-BETA1
>            Reporter: Eiji Kitamura
>            Priority: Minor
>             Fix For: 1.1-BETA2
>
>         Attachments: XOauthPublicKey.patch
>
>
> According to the discussion below, signature identifier param key should be 
> xoauth_public_key, not xoauth_signature_publickey as it is on current 
> implementation.
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/30d3183c5c2b4670/9f56e2f81380c319

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.