[
https://issues.apache.org/jira/browse/SHINDIG-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Chabot resolved SHINDIG-857.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
'Fixed' this by including both the old and new key names:
- protected static $XOAUTH_PUBLIC_KEY = "xoauth_signature_publickey";
+ protected static $XOAUTH_PUBLIC_KEY_OLD = "xoauth_signature_publickey";
+ protected static $XOAUTH_PUBLIC_KEY_NEW = "xoauth_public_key";
protected static $ALLOWED_PARAM_NAME = '^[-_[:alnum:]]+$';
/**
@@ -229,7 +230,8 @@
$msgParams[OAuth::$OAUTH_CONSUMER_KEY] = $domain;
}
if ($this->keyName != null) {
- $msgParams[SigningFetcher::$XOAUTH_PUBLIC_KEY] = $this->keyName;
+ $msgParams[SigningFetcher::$XOAUTH_PUBLIC_KEY_OLD] = $this->keyName;
+ $msgParams[SigningFetcher::$XOAUTH_PUBLIC_KEY_NEW] = $this->keyName;
}
Not the prettiest of solutions, but consistent with java-shindig and the apps
that are already out there at least.
> public key id param key should be xoauth_public_key
> ---------------------------------------------------
>
> Key: SHINDIG-857
> URL: https://issues.apache.org/jira/browse/SHINDIG-857
> Project: Shindig
> Issue Type: Improvement
> Components: PHP
> Affects Versions: 1.1-BETA1
> Reporter: Eiji Kitamura
> Assignee: Chris Chabot
> Priority: Minor
> Fix For: 1.1-BETA2
>
> Attachments: XOauthPublicKey.patch
>
>
> According to the discussion below, signature identifier param key should be
> xoauth_public_key, not xoauth_signature_publickey as it is on current
> implementation.
> http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/30d3183c5c2b4670/9f56e2f81380c319
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
