[ 
https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748450#action_12748450
 ] 

Les Hazlewood commented on SHIRO-91:
------------------------------------

I just re-enabled those tests but the fixes were superficial - ensuring a mock 
call was recognized.  But no underlying logic was changed.

Would you be able to create a test case that re-creates the issue?  I'll keep 
trying on my end, but I don't see anything at the moment.  The SubjectBuilder 
changes also didn't affect any of the WebRememberMeManager logic.  The only 
thing a WebRememberMeManager needs to function is a thread-bound 
ServletRequest/ServletResponse pair, and those were re-enabled 2 days ago - I 
can't think of what else would cause this to fail at the moment.  Any other 
additional info would be appreciated.

> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError 
> in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-91
>                 URL: https://issues.apache.org/jira/browse/SHIRO-91
>             Project: Shiro
>          Issue Type: Test
>          Components: Web
>    Affects Versions: 0.9
>         Environment: any
>            Reporter: Kalle Korhonen
>             Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and 
> getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is 
> commented out. If re-enabled, the tests won't succeed. RememberMe doesn't 
> seem to be working anymore after Subject was refactored and SubjectBuilder 
> introduced (I'll look into it more and probably open a different issue for 
> that one - but these tests need to be enabled to serve as regression testing 
> suite).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to