[
https://issues.apache.org/jira/browse/SHIRO-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748480#action_12748480
]
Kalle Korhonen commented on SHIRO-91:
-------------------------------------
As mentioned in my email, the issue with rememberMe is:
---
I see that Subject.login() now works again, but RememberMe is broken,
because the new DefaultSecurityManager.createSubject(Map context)
doesn't call getRememberedIdentity at any point. Compare to the old
createSubject() that does:
if (session != null) {
if (session.getAttribute(SessionSubjectBinder.PRINCIPALS_SESSION_KEY)
== null) {
remembered = getRememberedIdentity();
}
}
Should I open an issue or are you still working on it to complete this
refactoring?
---
Compare the createSubject() operations in DefaultSecurityManager -
rememberMeManager is never invoked in the new one.
> Tests for getRememberedPrincipals and getRememberedPrincipalsDecryptionError
> in WebRememberMeManagerTest are disabled
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-91
> URL: https://issues.apache.org/jira/browse/SHIRO-91
> Project: Shiro
> Issue Type: Test
> Components: Web
> Affects Versions: 0.9
> Environment: any
> Reporter: Kalle Korhonen
> Fix For: 1.0
>
>
> @Test annotation for getRememberedPrincipals and
> getRememberedPrincipalsDecryptionError tests in WebRememberMeManagerTest is
> commented out. If re-enabled, the tests won't succeed. RememberMe doesn't
> seem to be working anymore after Subject was refactored and SubjectBuilder
> introduced (I'll look into it more and probably open a different issue for
> that one - but these tests need to be enabled to serve as regression testing
> suite).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
