On Wed, Sep 16, 2009 at 1:33 PM, Kalle Korhonen <[email protected]> wrote: > I had two main suggestions. First, to favor composition over > inheritance in regards to configuration
Yep, my latest refactoring has us well on the way towards that goal. See the FilterChainResolver and FilterChainManager interfaces and their implementations that I added this week. Now any configuration mechanism can utilize both of these components instead of having to subclass an existing Configuration class. Hopefully this helps alleviate Tamás's concerns. > Second, I suggested that perhaps Shiro should use it's own Filter > interface rather than servlet filter. We had a WebInterceptor interface at one time, but removed it since the servlet Filter interface seemed to satisfy all of our needs. Even then, WebInterceptor was still Servlet Request/Response specific. Can you elaborate as to how this might work, with maybe a sample/intro API? My fear is that this approach would require us to replicate the Filter/FilterChain APIs and would probably break all of the existing Shiro filter end-user configurations - I don't know if we'd want to risk that :/ > Les, I see that you had > another thread on that topic, I'll respond to it as well. Looking forward to it! - Les
