Hi,

Last week I worked on the feedback for Plugins PR (it's ready to be merged
now) and a bit of using tags parameter in shogun classes. The latter part
is rather tricky and I think modifying SG_ADD is not a good way to do it.
Modifying SG_ADD won't mean not touching rest of the shogun classes, there
is no way to avoid that. The point of tags parameters was to get rid of
setters-getters in shogun and provide a better API. I'm trying to make
tags-parameters work for GaussianKernel in this PR
<https://github.com/shogun-toolbox/shogun/pull/3405>.

This week I'll work on my old PRs that are not yet merged. See my timeline
<https://docs.google.com/document/d/1ZVV9KsHxpoj2G3HYYp-8MNjDpHVL0RGvj5hD0r03lgg/edit?usp=sharing>
for more details.

Thanks,
Sanuj

Reply via email to