On 2 September 2012 15:25, Tom Eastep <[email protected]> wrote: > On 09/02/2012 07:04 AM, Tom Eastep wrote: >> On 09/01/2012 07:29 PM, Mr Dash Four wrote: >>>>> 9. Shorewall-init: From Fedora's perspective (don't know about >>>>> any other distros - this might be applicable there also) the >>>>> init.d script contains the following: >>>>> >>>>> restart|reload|force-reload) echo "Not implemented" exit 3 ;; >>>>> condrestart|try-restart) echo "Not implemented" exit 3 ;; >>>>> >>>>> The above could be collapsed into: >>>>> >>>>> restart|reload|force-reload|condrestart|try-restart) echo "Not >>>>> implemented" exit 3 ;; >>>> >>>> As I understand it, the Fedora init file standards require >>>> separate entries. >>> Separate entries for what? As it stands, all 6 conditionals are >>> collapsed into two equal set of statements. I don't see a problem >>> of going a step further and collapsing them all into one. > > The Fedora Shorewall maintainer is subscribed to the list; I'll let him > decide. >
While the suggestion is technically correct, it's simply a cosmetic fix - I think it's best just to leave it alone - after all, nothing is broken. Also init scripts are now legacy on Fedora systems anyway. Jonathan. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
