On 09/11/2012 05:14 PM, Mr Dash Four wrote:
I am sorry, but I can't see *any* of it.
OK, I prepared a (rather rudimentary) test case and I am attaching
the relevant files in this email - I hope the mailing list daemon
would accept the attachments, if not will send them privately.
In tcclasses I defined various classes for a single interface for
both ingress and egress (eth0->ifb0) with different priorities
ranging from 1 to 7. In the resulting compilation (shorewall compile
-T -p -e) file (see firewall_tc) I can see all of these classes and
flows defined, though I cannot see any of the priorities I have
specified in my tclcasses file.
That's because the code is neglecting to set the priority on hsfc
classes :-( Patch attached.
-Tom
--
Tom Eastep \ When I die, I want to go like my Grandfather who
Shoreline, \ died peacefully in his sleep. Not screaming like
Washington, USA \ all of the passengers in his car
http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm
index e69a5c4..f2d2c03 100644
--- a/Shorewall/Perl/Shorewall/Tc.pm
+++ b/Shorewall/Perl/Shorewall/Tc.pm
@@ -1945,7 +1945,7 @@ sub process_traffic_shaping() {
emit ( "run_tc class add dev $device parent $devicenumber:$parent classid $classid htb rate $rate ceil $tcref->{ceiling}kbit prio $tcref->{priority} \$${dev}_mtu1 quantum \$quantum" );
} else {
my $dmax = $tcref->{dmax};
- my $rule = "run_tc class add dev $device parent $devicenumber:$parent classid $classid hfsc";
+ my $rule = "run_tc class add dev $device parent $devicenumber:$parent classid $classid hfsc prio $tcref->{priority}";
if ( $dmax ) {
my $umax = $tcref->{umax} ? "$tcref->{umax}b" : "\${${dev}_mtu}b";
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Shorewall-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/shorewall-devel
