>> That's because the code is neglecting to set the priority on hsfc >> classes :-( Patch attached. > > Disregard the earlier patch -- hfsc doesn't support priority on its > classes. I'll have to work on a patch that allows PRIORITY to be omitted > on those classes. Damn! How is traffic prioritised then? By setting the dmax values? If priority is indeed not supported (and can't be supported!) for hfsc, then the right course of action would be to issue an error when something (anything!) is specified in the PRIORITY column, not simply ignore it, otherwise there will be others like me asking why is this value not honoured.
As far as hfsc goes, If I can't prioritise traffic I may have to change the discipline used. I used hsfc primarily because of the ability to specify dmax values. Apart from HTB (which I am not very keen on) and HSFC, is there another discipline I could use for traffic shaping? CBQ? Another question - you use "tc filter" for ifbX type devices, but not for others. Why? Can you not use hfsc for definition of classes and then create separate "tc filter" statements when you can define priorities. The man pages inform me that "tc filter" statements are "consulted" before a class is used, so, potentially, even if a priority is not defined (or can't be defined) in hfsc classes, that could be done in "tc filter" statements. Would that work? One other thing I spotted in the meantime: in the firewall_tc file I attached yesterday, the "quantum" variable defined in those 2 functions is not used anywhere, so you might consider removing it altogether. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Shorewall-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-devel
