On 1/27/2015 12:43 PM, Orion Poplawski wrote: > - I've attached a patch that adds xz support to the default MODULE_SUFFIX. > - I'm wondering it wouldn't be better to not have MODULE_SUFFX=ko in various > sample configs so that the default value is used instead: > > ./Shorewall/configfiles/shorewall.conf:MODULE_SUFFIX=ko > ./Shorewall/Samples/Universal/shorewall.conf:MODULE_SUFFIX=ko > ./Shorewall/Samples/three-interfaces/shorewall.conf:MODULE_SUFFIX=ko > ./Shorewall/Samples/two-interfaces/shorewall.conf:MODULE_SUFFIX=ko > ./Shorewall/Samples/one-interface/shorewall.conf:MODULE_SUFFIX=ko > ./docs/MultiISP.xml:MODULE_SUFFIX=ko > ./docs/MyNetwork.xml:MODULE_SUFFIX=ko > ./Shorewall6/configfiles/shorewall6.conf:MODULE_SUFFIX=ko > ./Shorewall6/Samples6/Universal/shorewall6.conf:MODULE_SUFFIX=ko > ./Shorewall6/Samples6/three-interfaces/shorewall6.conf:MODULE_SUFFIX=ko > ./Shorewall6/Samples6/two-interfaces/shorewall6.conf:MODULE_SUFFIX=ko > ./Shorewall6/Samples6/one-interface/shorewall6.conf:MODULE_SUFFIX=ko > > - Is: > > MODULE_SUFFIX= > > sufficient to use the default value or does it need to be commented out? >
It does not need to be commented out. The biggest problem with the default value is that it is slowwwwwwwwwww! And, until recently, all current distributions were using .ko for the kernel module suffix. So we may want to update the samples to specify MODULE_SUFFIX=ko,ko.xz? -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Shorewall-devel mailing list Shorewall-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-devel
