On 01/27/2015 04:03 PM, Tom Eastep wrote: > On 1/27/2015 12:43 PM, Orion Poplawski wrote: >> - I've attached a patch that adds xz support to the default MODULE_SUFFIX. >> - I'm wondering it wouldn't be better to not have MODULE_SUFFX=ko in various >> sample configs so that the default value is used instead: >> >> ./Shorewall/configfiles/shorewall.conf:MODULE_SUFFIX=ko >> ./Shorewall/Samples/Universal/shorewall.conf:MODULE_SUFFIX=ko >> ./Shorewall/Samples/three-interfaces/shorewall.conf:MODULE_SUFFIX=ko >> ./Shorewall/Samples/two-interfaces/shorewall.conf:MODULE_SUFFIX=ko >> ./Shorewall/Samples/one-interface/shorewall.conf:MODULE_SUFFIX=ko >> ./docs/MultiISP.xml:MODULE_SUFFIX=ko >> ./docs/MyNetwork.xml:MODULE_SUFFIX=ko >> ./Shorewall6/configfiles/shorewall6.conf:MODULE_SUFFIX=ko >> ./Shorewall6/Samples6/Universal/shorewall6.conf:MODULE_SUFFIX=ko >> ./Shorewall6/Samples6/three-interfaces/shorewall6.conf:MODULE_SUFFIX=ko >> ./Shorewall6/Samples6/two-interfaces/shorewall6.conf:MODULE_SUFFIX=ko >> ./Shorewall6/Samples6/one-interface/shorewall6.conf:MODULE_SUFFIX=ko >> >> - Is: >> >> MODULE_SUFFIX= >> >> sufficient to use the default value or does it need to be commented out? >> > > It does not need to be commented out. The biggest problem with the > default value is that it is slowwwwwwwwwww! And, until recently, all > current distributions were using .ko for the kernel module suffix.
I was wondering if that was the case. > > So we may want to update the samples to specify MODULE_SUFFIX=ko,ko.xz? That's probably the way to go (perhaps in addition to the patch, or some other cleaned up default) - somehow didn't think to specify multiple values in the config file. Is comma separated the proper syntax? It's space separated in the code. > > -Tom -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane or...@cora.nwra.com Boulder, CO 80301 http://www.cora.nwra.com ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Shorewall-devel mailing list Shorewall-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/shorewall-devel
