Hi >> Grateful if you would consider accepting this functionality into the >> next shorewall release (for me a large performance increase, and >> eliminated of a dependency) > > Hi Ed, > > This patch *should* be unnecessary. If you don't want Shorewall to use > 'make' then:
Let me rephrase my problem description: I *want* the AUTO_MAKE=Yes type functionality, ie that the rules are only compiled if they have changed, but I don't want to have to install "make" on the target box to achieve this functionality Does that make sense? The only place I can see "make" being used in the code is two small places which only call "make -q" (-q = run no commands), ie shorewall does not appear to *call* make to do any work, it only uses it as a (very expensive) test to see if any /etc/shorewall/* files are updated. However, as you can easily see, this can easily be done much more cheaply without calling the make binary itself. So if you apply my patch and test it with AUTO_MAKE=Yes, then you should see that shorewall still functions as before, however, performance is substantially improved during restart and there is no dependency on the make executable (as my stats show, it saves around 0.5sec or 1/3 of the time needed to restart) Note, nothing in this patch stops a user installing "make" and running it in /etc/shorewall - this still works fine. However, that was what my mutterings about unused code meant - you *could* simplify the Makefile and move the functionality into the /sbin/shorewall file, however, I suspect you will actually prefer to leave as is, hence cull that additional function. However, I left it in so you can see the idea? I hope this clarifies the situation and you will look again at the patch? Thanks Ed W ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Shorewall-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-users
