On 05/01/2013 09:34 AM, KP Kirchdörfer wrote: > Hi Tom; > > I see the following (cosmetic?) pb after having updated shorewall(6) > on a LEAF box: > > Use of uninitialized value $Shorewall::Config::sillyname in > concatenation (.) or string at > /usr/share/shorewall/Shorewall/Config.pm line 3907. > > > Note I haven't updated configs, maybe this causes the error messages? >
Corrected by the attached patch. 4.5.16.1 coming shortly. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________
diff --git a/Shorewall/Perl/Shorewall/Config.pm b/Shorewall/Perl/Shorewall/Config.pm
index 6a26546..904168f 100644
--- a/Shorewall/Perl/Shorewall/Config.pm
+++ b/Shorewall/Perl/Shorewall/Config.pm
@@ -1185,14 +1185,24 @@ sub cleanup() {
qt1( "$iptables -X $sillyname" );
qt1( "$iptables -F $sillyname1" );
qt1( "$iptables -X $sillyname1" );
- qt1( "$iptables -t mangle -F $sillyname" );
- qt1( "$iptables -t mangle -X $sillyname" );
- qt1( "$iptables -t nat -F $sillyname" );
- qt1( "$iptables -t nat -X $sillyname" );
- qt1( "$iptables -t raw -F $sillyname" );
- qt1( "$iptables -t raw -X $sillyname" );
- qt1( "$iptables -t rawpost -F $sillyname" );
- qt1( "$iptables -t rawpost -X $sillyname" );
+
+ if ( $capabilities{MANGLE_ENABLED} ) {
+ qt1( "$iptables -t mangle -F $sillyname" );
+ qt1( "$iptables -t mangle -X $sillyname" );
+ }
+
+ if ( $capabilities{NAT_ENABLED} ) {
+ qt1( "$iptables -t nat -F $sillyname" );
+ qt1( "$iptables -t nat -X $sillyname" );
+ }
+
+ if ( $capabilities{RAW_TABLE} ) {
+ qt1( "$iptables -t raw -F $sillyname" );
+ qt1( "$iptables -t raw -X $sillyname" );
+ }
+
+ $sillyname = $sillyname1 = undef;
+
$sillyname = '';
}
}
@@ -4335,27 +4345,6 @@ sub determine_capabilities() {
$capabilities{HELPER_MATCH} = detect_capability 'HELPER_MATCH';
}
- qt1( "$iptables -F $sillyname" );
- qt1( "$iptables -X $sillyname" );
- qt1( "$iptables -F $sillyname1" );
- qt1( "$iptables -X $sillyname1" );
-
- if ( $capabilities{MANGLE_ENABLED} ) {
- qt1( "$iptables -t mangle -F $sillyname" );
- qt1( "$iptables -t mangle -X $sillyname" );
- }
-
- if ( $capabilities{NAT_ENABLED} ) {
- qt1( "$iptables -t nat -F $sillyname" );
- qt1( "$iptables -t nat -X $sillyname" );
- }
-
- if ( $capabilities{RAW_TABLE} ) {
- qt1( "$iptables -t raw -F $sillyname" );
- qt1( "$iptables -t raw -X $sillyname" );
- }
-
- $sillyname = $sillyname1 = undef;
}
}
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________ Shorewall-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/shorewall-users
