First of all I would like to thanks you for creating this application. I
was very excited when I firstly launch it. Gnome was missing feature
rich photo manager for long time and I must admit that I never liked
f-spot.
I have some remark about source code.
Although Vala's syntax is very similar to Java or C# I think that
sourcefile organization should not follow Java or C# way as I felt it in
your project. In my opinion when you run valac over Vala project the
result should look like as gnome module written purely in c.
What does it mean for Shotwell? Please separate library and application
(UI) code to individual directories. For example like in Rhythmbox, they
have shell directory for UI, rhytmdb for data, widgets, sources and so
on. Leave one class per file. Follow gnome sourcefile name convention.
This is very often in format "directory-classname". In sourcefiles use
"namespace" keyword - it should save your work. For example file:
\shotwelldb
shotwelldb-import.vala
will include:
namespace Shotwelldb {
class Import : ...
//some code
}
I like the way that is used by Cannonical in their Unity project:
http://bazaar.launchpad.net/~unity-team/unity/trunk/files
I know it's lot of boring labor. But I think I will help shotwell to fit
more in gnome environment and it should be more convenient for gnome
developer. Maybe its an good idea to try push project to gnome git - at
will gain more love and care :)
There are only humble recommendations that I believe will help the
project to grow. For me is very difficult to orient in shotwells code
organization, mostly because library and application functions are mixed.
I have some ideas about GUI and usability I will try to write them latter.
Yours,
Stanislav Nowak
_______________________________________________
Shotwell mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
