On 01.07.2014 02:19 UTC+0200, Ben Deering wrote:
> GTA04 hardware supports fixed blink rates. If the requested blink rate
> is not close (within 12%) of a supported rate, blinking will not
> continue in suspend. Set the blink rate to the closest supported rate.
>
> Signed-off-by: Ben Deering <ben_deer...@swissmail.org>
> ---
> framework/subsystems/oeventsd/leds_actions.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/subsystems/oeventsd/leds_actions.py
> b/framework/subsystems/oeventsd/leds_actions.py
> index ffdf21a..77b96d1 100644
> --- a/framework/subsystems/oeventsd/leds_actions.py
> +++ b/framework/subsystems/oeventsd/leds_actions.py
> @@ -78,7 +78,7 @@ class Led(object):
>
> def __blink(self):
> logger.info("blink led %s", self)
> - self.interface.SetBlinking(100, 1500, reply_handler=self.on_reply,
> error_handler=self.on_error)
> + self.interface.SetBlinking(128, 2048, reply_handler=self.on_reply,
> error_handler=self.on_error)
>
> def turn_on(self, user):
> self.users[user] = 'on'
> Hi Ben, IMO we should handle this in a more device-independent way. Those values might be good for the GTA04, but might be bad for another (maybe future) device. So can we maybe make it a configuration option, so we can specify the values on per-device basis? BR, Lukas
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Shr-devel mailing list Shr-devel@lists.shr-project.org http://lists.shr-project.org/mailman/listinfo/shr-devel
