Hi Mathias, I'm glad to see that you've been able to adapt my DS1xx2 driver to support the DS2xx2 series.
Looking through the code, it seems that the differences between the two are relatively minor and as such there is a lot of code duplicated between the ds1xx2 and ds2xx2 drivers after applying your patch. I think it would be better for future maintenance if we could merge the two into a single "dsxxx2" driver that supported both series. I could help with this work and test on the two DS1xx2 scopes at my lab, if you could test against a DSxx2. Looking through the diff between ds1xx2 and ds2xx2, it looks like the main changes required to support both would be: - Adjusting the list of supported timebase and vdiv settings according to the actual model of scope connected (which we ought to be doing anyway, as the available timebases vary between the bandwidth options even on the DS1xx2 series, and the vdiv settings depend on the probe gain). - Omitting the digital channels for the DS2xx2 series (simple, since this is already done for the DS1xx2 models that don't have them). - Adjusting the waveform readout protocol for the DS2xx2 series. - Adding the vertical reference support. Have I missed anything? Martin On Sun, Oct 20, 2013 at 09:41:18PM +0200, Mathias Grimmberger wrote: > > > Hi everybody, > > I cobbled together a first version of hardware support for the Rigol > DS2xx2 series oscilloscopes (models DS2072, DS2102, DS2202). > > It is heavily based on the rigol-ds1xx2 code. Because of this it shares > its quirks. > > Grabbing the displayed samples (1400 per channel) works when the scope > is running, when stopped this only works if the horizontal settings > haven't been changed. > > > Enjoy, > > MGri ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
