Hi Martin, Martin Ling writes: > > I think it would be better for future maintenance if we could merge the > two into a single "dsxxx2" driver that supported both series.
The thought crossed my mind too, but then I took the fast, easy and safe route... > I could help with this work and test on the two DS1xx2 scopes at my > lab, if you could test against a DSxx2. OK, thank you. > Looking through the diff between ds1xx2 and ds2xx2, it looks like the > main changes required to support both would be: > > - Adjusting the list of supported timebase and vdiv settings according to > the actual model of scope connected (which we ought to be doing anyway, > as the available timebases vary between the bandwidth options even on > the DS1xx2 series, and the vdiv settings depend on the probe gain). > > - Omitting the digital channels for the DS2xx2 series (simple, since > this is already done for the DS1xx2 models that don't have them). > > - Adjusting the waveform readout protocol for the DS2xx2 series. > > - Adding the vertical reference support. > > Have I missed anything? I want to implement some more of the stuff the DS2xx2 can do, specifically: - reading the complete sample memory when the scope is stopped, - reading samples taken in HiRes mode (12 bits per sample), - at least check out what is there in peak detect aquisition mode. For that I will keep the code separate for now. When I have understood how all this works a unified driver can be started. BTW, a glance through the programming manuals of the DS4000 and DS6000 series scopes shows them using the same command structure as the DS2000 series. I guess we can have a single driver covering the DS1xx2, DS2000, DS4000 and DS6000 series. Likely DS1000Z series too, but I have no programming manual for that yet. MGri ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
