Hi Bert, thank you for your answer.

I can confirm that the 189 uses the same "QM" command as the 187:
<-- QM\r
--> QM,+03.225 mV AC

The fluke189 is working now, after one more minor modification of the code:
$./sigrok-cli -d fluke-dmm:conn=/dev/cu.usbserial-A3000LQv:serialcomm=9600/8n1 
--samples 1 -O analog
P1: -0.053000 mV DC

I've made a git patch, is it ok to just submit it here in the list ? I'm not 
very familiar with git so you will have to forgive me if it isn't properly 
formatted.

PS: It seems like I'm not receiving all the e-mail from the list (I've checked 
the settings, they are ok), so I guess I'll occasionally check the archive on 
the website. You can always CC me directly if you need to contact me (I don't 
mind the duplicates).

Fabio




[PATCH] Add Fluke189 support.

---
 hardware/fluke-dmm/api.c       |    1 +
 hardware/fluke-dmm/fluke-dmm.h |    1 +
 hardware/fluke-dmm/fluke.c     |    2 +-
 3 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/hardware/fluke-dmm/api.c b/hardware/fluke-dmm/api.c
index 08cd62f..d9d3d9b 100644
--- a/hardware/fluke-dmm/api.c
+++ b/hardware/fluke-dmm/api.c
@@ -54,6 +54,7 @@ static char *scan_conn[] = {
 
 static const struct flukedmm_profile supported_flukedmm[] = {
        { FLUKE_187, "187", 100, 1000 },
+       { FLUKE_189, "189", 100, 1000 },
        { FLUKE_287, "287", 100, 1000 },
        { FLUKE_190, "199B", 1000, 3500 },
 };
diff --git a/hardware/fluke-dmm/fluke-dmm.h b/hardware/fluke-dmm/fluke-dmm.h
index 4291be0..d162bdd 100644
--- a/hardware/fluke-dmm/fluke-dmm.h
+++ b/hardware/fluke-dmm/fluke-dmm.h
@@ -27,6 +27,7 @@
 /* Supported models */
 enum {
        FLUKE_187 = 1,
+       FLUKE_189,
        FLUKE_287,
        FLUKE_190,
 };
diff --git a/hardware/fluke-dmm/fluke.c b/hardware/fluke-dmm/fluke.c
index 962c4f4..493bcc1 100644
--- a/hardware/fluke-dmm/fluke.c
+++ b/hardware/fluke-dmm/fluke.c
@@ -435,7 +435,7 @@ static void handle_line(const struct sr_dev_inst *sdi)
        analog = NULL;
        tokens = g_strsplit(devc->buf, ",", 0);
        if (tokens[0]) {
-               if (devc->profile->model == FLUKE_187) {
+               if (devc->profile->model == FLUKE_187 || devc->profile->model 
== FLUKE_189) {
                        devc->expect_response = FALSE;
                        analog = handle_qm_18x(sdi, tokens);
                } else if (devc->profile->model == FLUKE_287) {
-- 
1.7.5.4


------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
sigrok-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to