On 07/03/2014 06:59 AM, Peter Stuge wrote:
> Kumar Abhishek wrote:
>> These patches add BeagleLogic support to libsigrok.
>
> Patch 1 (.gitignore) should be sent independently of BeagleLogic, if
> at all. Please clarify if it will be accepted at all.
Looks like something for your global .gitignore instead, yeah.
> Please squash patches 2-4 into a single commit which directly adds a
> complete and functional driver.
A small correction: we do like to see patch 2 ("Initial driver skeleton") as
a separate commit. This is boilerplate generated by our new-driver tool, and
the first patch after that is thus entirely non-boilerplate. We also like to
see that new-driver has been used in the first place.
Other than that, Peter's comments are right on the money.
--
Bert Vermeulen b...@biot.com email/xmpp
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel
