Hi, On Thu, Sep 04, 2014 at 12:58:20AM +0200, Slawek Piotrowski wrote: > Ups, I did not switch to plain text mode. > > In previous email I've attached the patch which adds the decoder for > RFM12 chips by HopeRF > (http://www.hoperf.com/rf/fsk_module/RFM12B.htm). > > This is a popular and cheap RF module which communicates with > microcontroller through an SPI based protocol. > > I've also attached an example signal recorded using real module.
Awesome, thanks for your contribution! I've merged the decoder with a few whitespace/consistency changes (no camelCase, 4 spaces for indentation as per Python PEP-8, etc) and dropped a few unused functions and variables etc. I also added your copyright lines in the code, they were (C) Uwe Hermann (since you probably started out with some PD I wrote), but the current rfm12 code doesn't contain anything non-trivial that's written by me, so I dropped my copyright lines. I also noticed a typo (I think) and changed the 912MHz -> 915MHz as per datasheet. The datasheet also says frequency bits == 00 means 315MHz, so I added that as well. Or is there any specific reason it was not contained? The rfm12.sr file is merged in sigrok-dumps now. It would be nice if you could add a small README for that as well, see other READMEs in sigrok-dumps for examples. I've also added a quick test in our sigrok-test repository (which contains "unit tests" for specific decoders basically): http://sigrok.org/gitweb/?p=sigrok-test.git;a=tree;f=decoder/test/rfm12 It would be nice if you could make a few more *.sr files for the sigrok-dumps repo and add a few more test-cases to sigrok-test in order to check the full functionality of the decoder and achieve 100% code coverage where possible. Specifically, I think handle_synchron_pattern_cmd() may not work correctly, it seems to use a "pattern" variable that doesn't exist. Btw, it would be nice if you could make a small wiki page for the decoder, including one or two photos of the RFM12 + setup you used for probing possibly, and some info + URLs about the RFM12. See e.g. these pages for such PD wiki pages as example: http://sigrok.org/wiki/Protocol_decoder:Dcf77 http://sigrok.org/wiki/Protocol_decoder:Mx25lxx05d http://sigrok.org/wiki/Protocol_decoder:Nrf24l01 If you can do that, let us know which wiki username you'd like and/or join us on the #sigrok IRC channel. Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
