Hi, Thanks for reviewing my code and including it in official repository. Also see my answers below.
On Mon, Sep 8, 2014 at 12:47 PM, Uwe Hermann <[email protected]> wrote: > I also noticed a typo (I think) and changed the 912MHz -> 915MHz as per > datasheet. Right, thanks > The datasheet also says frequency bits == 00 means 315MHz, so > I added that as well. Or is there any specific reason it was not > contained? There are two versions of the chip. Older RFM12 and newer RFM12B. The datasheet for RFM12 says 315MHz. The one for RFM12B says the value is reserved. I think we can stay with 315MHz. > Specifically, I think handle_synchron_pattern_cmd() may not work > correctly, it seems to use a "pattern" variable that doesn't exist. Right. I will fix that. I will also try to add the tests, README, wiki, etc. like you described. > If you can do that, let us know which wiki username you'd like I would prefer username 'sentinel'. I have one request. I've left an email of the company I work for in the commit message by mistake. Please change the email in a copyright section to [email protected]. Thanks. Regards, Sławek ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
