Hi,

On Thu, Feb 05, 2015 at 05:30:58PM +0100, Bartosz Golaszewski wrote:
> +     /**
> +      * The device is a power-monitor supporting remote power-off/on
> +      * of measured devices.
> +      */
> +     SR_CONF_POWER_SWITCH,

Hm, this may need a clearer name. Switching on and off certain devices
or probes or whatever is probably not specific to a "power-monitor",
correct? Note that there's already SR_CONF_POWER_OFF as well:

        /** Power off the device. */
        SR_CONF_POWER_OFF,

Not quite the same thing, but adding the very generic
SR_CONF_POWER_SWITCH probably adds confusion here. Any ideas for
clearer naming?

Also, please split the generic libsigrok additions off into an extra
patch, it's unrelated to the ACME driver stuff per se.


Uwe.
-- 
http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
sigrok-devel mailing list
sigrok-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sigrok-devel

Reply via email to