Hi, On Wed, Nov 11, 2015 at 08:39:46PM -0800, Vincent Palatin wrote: > Hi Sigrok developers, > > I have written a protocol decoder for the USB Power Delivery release > 2.0 v1.1 with BMC encoding as found on the Control Channel pins of the > USB Type-C connectors. > The current set of patches can be found on the following github repositories : > https://github.com/vpalatin/libsigrokdecode > https://github.com/vpalatin/sigrok-dumps > https://github.com/vpalatin/sigrok-test > Let me know if you need some changes or want those 3 patches inlined > inside emails for further reviews.
Merged, thanks a lot! I did some minor whitespace cleanup and made the .sr files non-executable, otherwise the stuff looks pretty good, thanks! It's also great that you included both, .sr files *and* some test-cases for them! If you have some time feel free to use single-quotes consistently for strings to match the conventions in the rest of the PDs, but this is a minor issue. I've seen some more PDs in Chromium such as usb_pd_packet, usb_pd_vbus_voltage, usb_pd_bmc, usb_pd_vbus_current -- are those unrelated or have they all been merged into this usb_power_delivery PD? > I also have some patches in preparation for a libsigrok driver for the > 'Twinkie' USB type-C interposer and analyzer which is a convenient > open-source hardware to dump USB Type-C traces but they require more > work before submission. Sounds great! Cheers, Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ sigrok-devel mailing list sigrok-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sigrok-devel
