Hi, On Thu, Oct 20, 2016 at 11:58:41AM +0200, Gerhard Sittig wrote: > Got the Peaktech 3330 DMM as well as the Peaktech 2170 LCR meter > to work with sigrok. The former needs a simple serial-dmm entry > (attached). The latter is 100% compatible with existing support > for a device, but the ES51919 chip support was broken (patch is > attached). I'm also providing quick notes, for the record.
Both merged, thanks a lot! I assume you have both devices? Could you please add a wiki page for each, together with the usual info (hardware, lsusb, vendor URLs, etc.) and (self-made) photos if possible? Contact us on IRC for a wiki account, or let us know on the ML which username you'd like. Example page: http://sigrok.org/wiki/UNI-T_UT61D > About the serial-dmm table: I could not determine by which order > the entries are sorted. It's neither vendor/product, nor chipset. > Is it "order of introduction of support" (patch submission)? > This is of minor importance, as sigrok-cli(1) helpfully sorts the > list of supported devices. :) Yup, probably unsorted for now. Feel free to sort by driver name (e.g. "radioshack-22-805") in a patch :) > + DMM( > + "peaktech-3330", fs9721, > + "Peaktech", "3330", "2400/8n1/dtr=1", 2400, > + FS9721_PACKET_SIZE, 0, 0, NULL, > + sr_fs9721_packet_valid, sr_fs9721_parse, > + sr_fs9721_01_10_temp_f_c I assume you checked that sr_fs9721_01_10_temp_f_c is the correct function for this device? There are a few bits that are device-dependent here, even if the FS9721 chip is the same. Uwe. -- http://hermann-uwe.de | http://randomprojects.org | http://sigrok.org ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sigrok-devel
